Allow fixed parameters and direct NLL. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleeman
force-pushed
the
update_priors_and_nll
branch
2 times, most recently
from
1e94fb4 to
61a849c
Compare
akleeman
commented
Jul 24, 2018
albatross/core/priors.h
Outdated
| CEREAL_REGISTER_TYPE(albatross::UniformPrior); | ||
| CEREAL_REGISTER_TYPE(albatross::GaussianPrior); | ||
| CEREAL_REGISTER_TYPE(albatross::LogNormalPrior); | ||
| CEREAL_REGISTER_TYPE_WITH_NAME(albatross::UninformativePrior, |
There was a problem hiding this comment.
@benjamin0 note that this change should make the serialized JSON files a little easier to read, but at the price of non-backward compatible serialization. Let me know if you think it'll be too much of a pain to recreate the serialized models we're currently using.
Add a negative log likelihood for Gaussian processes.
akleeman
force-pushed
the
update_priors_and_nll
branch
from
61a849c to
0d0554c
Compare
benjamin0
approved these changes
Jul 25, 2018
This was referenced Dec 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for parameters which are fixed (so will not be tuned.)
Add a negative log likelihood for Gaussian processes.